Move the shortcode parser to the new pageparser package #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
parser-rework
branch
28 times, most recently
from
2d5edc2 to
6caf58d
Compare
Now that we have a proper page parse tree, this can be greatly simplified. See gohugoio#5324
And remove some now unused code. See gohugoio#5324
bep
force-pushed
the
parser-rework
branch
2 times, most recently
from
d055e5a to
b1f6104
Compare
bep
force-pushed
the
parser-rework
branch
3 times, most recently
from
d97d280 to
ecfa500
Compare
`*json.UnmarshalTypeError` and `*json.SyntaxError` has a byte `Offset`, so use that. This commit also reworks/simplifies the errror line matching logic. This also makes the file reading unbuffered, but that should be fine in this error case. See gohugoio#5324
bep
force-pushed
the
parser-rework
branch
3 times, most recently
from
b296872 to
45a44a4
Compare
bep
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5324